Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 916d11b2 authored by Borislav Petkov's avatar Borislav Petkov
Browse files

amd64_edac: fix DRAM base and limit address extraction 



K8 DRAM base and limit addresses from F1x40 +8*i and F1x44 + 8*i, where
i in (0..7) are both bits 39-24 and therefore the shifting should be
done by 24 and not by 8.

Signed-off-by: default avatarBorislav Petkov <borislav.petkov@amd.com>
parent 3011b20d

drivers/edac/amd64_edac.c

+2 −2
Original line number Diff line number Diff line
@@ -1130,7 +1130,7 @@ static void k8_read_dram_base_limit(struct amd64_pvt *pvt, int dram) 
		debugf0("Reading K8_DRAM_BASE_LOW failed\n");



	/* Extract parts into separate data entries */

	pvt->dram_base[dram] = ((u64) low & 0xFFFF0000) << 8;

	pvt->dram_base[dram] = ((u64) low & 0xFFFF0000) << 24;

	pvt->dram_IntlvEn[dram] = (low >> 8) & 0x7;

	pvt->dram_rw_en[dram] = (low & 0x3);
@@ -1143,7 +1143,7 @@ static void k8_read_dram_base_limit(struct amd64_pvt *pvt, int dram) 
	 * Extract parts into separate data entries. Limit is the HIGHEST memory

	 * location of the region, so lower 24 bits need to be all ones

	 */

	pvt->dram_limit[dram] = (((u64) low & 0xFFFF0000) << 8) | 0x00FFFFFF;

	pvt->dram_limit[dram] = (((u64) low & 0xFFFF0000) << 24) | 0x00FFFFFF;

	pvt->dram_IntlvSel[dram] = (low >> 8) & 0x7;

	pvt->dram_DstNode[dram] = (low & 0x7);

}