Commit 90ad30e5 authored Dec 10, 2014 by Joe Perches Committed by Linus Torvalds Dec 10, 2014

checkpatch: add test for consecutive string fragments



Emit a warning when single line string coalescing occurs.

Code that uses compiler string concatenation on a single line like:

    printk("foo" "bar");

is generally better to read concatenated like:

    printk("foobar");

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 0ab90191

scripts/checkpatch.pl

+6 −0

Original line number	Diff line number	Diff line
		@@ -4464,6 +4464,12 @@ sub process {
		"Concatenated strings should use spaces between elements\n" . $herecurr);
		}

		# uncoalesced string fragments
		if ($line =~ /"X"\s"/) {
		WARN("STRING_FRAGMENTS",
		"Consecutive strings are generally better as a single string\n" . $herecurr);
		}

		# warn about #if 0
		if ($line =~ /^.\s\#\sif\s+0\b/) {
		CHK("REDUNDANT_CODE",