Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 90922a2d authored by Shanker Donthineni's avatar Shanker Donthineni Committed by Marc Zyngier
Browse files

irqchip/gicv3-its: Add workaround for QDF2400 ITS erratum 0065 



On Qualcomm Datacenter Technologies QDF2400 SoCs, the ITS hardware
implementation uses 16Bytes for Interrupt Translation Entry (ITE),
but reports an incorrect value of 8Bytes in GITS_TYPER.ITTE_size.

It might cause kernel memory corruption depending on the number
of MSI(x) that are configured and the amount of memory that has
been allocated for ITEs in its_create_device().

This patch fixes the potential memory corruption by setting the
correct ITE size to 16Bytes.

Cc: stable@vger.kernel.org
Signed-off-by: default avatarShanker Donthineni <shankerd@codeaurora.org>
Signed-off-by: default avatarMarc Zyngier <marc.zyngier@arm.com>
parent b3e22847

Documentation/arm64/silicon-errata.txt

+1 −0
Original line number Diff line number Diff line
@@ -68,3 +68,4 @@ stable kernels. 
|                |                 |                 |                             |

| Qualcomm Tech. | Falkor v1       | E1003           | QCOM_FALKOR_ERRATUM_1003    |

| Qualcomm Tech. | Falkor v1       | E1009           | QCOM_FALKOR_ERRATUM_1009    |

| Qualcomm Tech. | QDF2400 ITS     | E0065           | QCOM_QDF2400_ERRATUM_0065   |

arch/arm64/Kconfig

+10 −0
Original line number Diff line number Diff line
@@ -508,6 +508,16 @@ config QCOM_FALKOR_ERRATUM_1009 


	  If unsure, say Y.



config QCOM_QDF2400_ERRATUM_0065

	bool "QDF2400 E0065: Incorrect GITS_TYPER.ITT_Entry_size"

	default y

	help

	  On Qualcomm Datacenter Technologies QDF2400 SoC, ITS hardware reports

	  ITE size incorrectly. The GITS_TYPER.ITT_Entry_size field should have

	  been indicated as 16Bytes (0xf), not 8Bytes (0x7).



	  If unsure, say Y.



endmenu

drivers/irqchip/irq-gic-v3-its.c

+16 −0
Original line number Diff line number Diff line
@@ -1601,6 +1601,14 @@ static void __maybe_unused its_enable_quirk_cavium_23144(void *data) 
	its->flags |= ITS_FLAGS_WORKAROUND_CAVIUM_23144;

}



static void __maybe_unused its_enable_quirk_qdf2400_e0065(void *data)

{

	struct its_node *its = data;



	/* On QDF2400, the size of the ITE is 16Bytes */

	its->ite_size = 16;

}



static const struct gic_quirk its_quirks[] = {

#ifdef CONFIG_CAVIUM_ERRATUM_22375

	{
@@ -1617,6 +1625,14 @@ static const struct gic_quirk its_quirks[] = { 
		.mask	= 0xffff0fff,

		.init	= its_enable_quirk_cavium_23144,

	},

#endif

#ifdef CONFIG_QCOM_QDF2400_ERRATUM_0065

	{

		.desc	= "ITS: QDF2400 erratum 0065",

		.iidr	= 0x00001070, /* QDF2400 ITS rev 1.x */

		.mask	= 0xffffffff,

		.init	= its_enable_quirk_qdf2400_e0065,

	},

#endif

	{

	}