Commit 90706094 authored Aug 18, 2016 by Eric Wheeler

bcache: pr_err: more meaningful error message when nr_stripes is invalid



The original error was thought to be corruption, but was actually caused by:
	make-bcache --data-offset N
where N was in bytes and should have been in sectors.  While userspace
tools should be updated to check --data-offset beyond end of volume,
hopefully this will help others that might not have noticed the units.

Signed-off-by: Eric Wheeler <bcache@linux.ewheeler.net>
Cc: Kent Overstreet <kent.overstreet@gmail.com>

parent acc9cf8c

drivers/md/bcache/super.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -760,7 +760,8 @@ static int bcache_device_init(struct bcache_device *d, unsigned block_size,
		if (!d->nr_stripes \|\|
		d->nr_stripes > INT_MAX \|\|
		d->nr_stripes > SIZE_MAX / sizeof(atomic_t)) {
		pr_err("nr_stripes too large");
		pr_err("nr_stripes too large or invalid: %u (start sector beyond end of disk?)",
		(unsigned)d->nr_stripes);
		return -ENOMEM;
		}