Commit 8ffcfd9d authored May 06, 2007 by Mikael Pettersson Committed by Jeff Garzik May 09, 2007

sata_promise: fix another error decode regression



The sata_promise error decode update changed pdc_host_intr()
to return and not complete the qc after detecting an error.
Unfortunately not completing the qc:s causes them to always
time out on error, which is wrong and has nasty side-effects.

This patch updates pdc_error_intr() to call ata_port_abort(),
similar to ahci and sata_sil24. Doing this is important as it
makes EH see the original error and not a bogus timeout.

Signed-off-by: Mikael Pettersson <mikpe@it.uu.se>
Signed-off-by: Jeff Garzik <jeff@garzik.org>

parent 48be6b18

drivers/ata/sata_promise.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -45,7 +45,7 @@
		#include "sata_promise.h"

		#define DRV_NAME "sata_promise"
		#define DRV_VERSION "2.05"
		#define DRV_VERSION "2.06"


		enum {
		@@ -653,6 +653,8 @@ static void pdc_error_intr(struct ata_port ap, struct ata_queued_cmd qc,
		qc->err_mask \|= ac_err_mask;

		pdc_reset_port(ap);

		ata_port_abort(ap);
		}

		static inline unsigned int pdc_host_intr( struct ata_port *ap,