Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8fe6e53a authored by Li Zhijian's avatar Li Zhijian Committed by Shuah Khan
Browse files

selftests/cpu-hotplug: exit with failure when test occured unexpected behaviors 



Previously, 'make run_tests -C cpu-hotplug' always PASS since cpu-on-off-test.sh
always exits 0 even though the test got some unexpected errors like below:
root@debian9:/home/lizhijian/chroot/linux/tools/testing/selftests/cpu-hotplug# make run_tests
pid 878's current affinity mask: 1
pid 878's new affinity mask: 1
CPU online/offline summary:
Cpus in online state: 0
        Cpus in offline state: 0
Limited scope test: one hotplug cpu
        (leaves cpu in the original state):
        online to offline to online: cpu 0
./cpu-on-off-test.sh: line 83: /sys/devices/system/cpu/cpu0/online: Permission denied
offline_cpu_expect_success 0: unexpected fail
./cpu-on-off-test.sh: line 78: /sys/devices/system/cpu/cpu0/online: Permission denied
online_cpu_expect_success 0: unexpected fail
selftests: cpu-on-off-test.sh [PASS]

after this patch, the test will exit with failure once it occurs some unexpected behaviors

Signed-off-by: default avatarLi Zhijian <lizhijian@cn.fujitsu.com>
Signed-off-by: default avatarShuah Khan <shuahkh@osg.samsung.com>
parent b274e75c

tools/testing/selftests/cpu-hotplug/cpu-on-off-test.sh

+8 −0
Original line number Original line Diff line number Diff line
@@ -89,8 +89,10 @@ online_cpu_expect_success() 




	if ! online_cpu $cpu; then

	if ! online_cpu $cpu; then

		echo $FUNCNAME $cpu: unexpected fail >&2

		echo $FUNCNAME $cpu: unexpected fail >&2

		exit 1

	elif ! cpu_is_online $cpu; then

	elif ! cpu_is_online $cpu; then

		echo $FUNCNAME $cpu: unexpected offline >&2

		echo $FUNCNAME $cpu: unexpected offline >&2

		exit 1

	fi

	fi

}

}
@@ -100,8 +102,10 @@ online_cpu_expect_fail() 




	if online_cpu $cpu 2> /dev/null; then

	if online_cpu $cpu 2> /dev/null; then

		echo $FUNCNAME $cpu: unexpected success >&2

		echo $FUNCNAME $cpu: unexpected success >&2

		exit 1

	elif ! cpu_is_offline $cpu; then

	elif ! cpu_is_offline $cpu; then

		echo $FUNCNAME $cpu: unexpected online >&2

		echo $FUNCNAME $cpu: unexpected online >&2

		exit 1

	fi

	fi

}

}
@@ -111,8 +115,10 @@ offline_cpu_expect_success() 




	if ! offline_cpu $cpu; then

	if ! offline_cpu $cpu; then

		echo $FUNCNAME $cpu: unexpected fail >&2

		echo $FUNCNAME $cpu: unexpected fail >&2

		exit 1

	elif ! cpu_is_offline $cpu; then

	elif ! cpu_is_offline $cpu; then

		echo $FUNCNAME $cpu: unexpected offline >&2

		echo $FUNCNAME $cpu: unexpected offline >&2

		exit 1

	fi

	fi

}

}
@@ -122,8 +128,10 @@ offline_cpu_expect_fail() 




	if offline_cpu $cpu 2> /dev/null; then

	if offline_cpu $cpu 2> /dev/null; then

		echo $FUNCNAME $cpu: unexpected success >&2

		echo $FUNCNAME $cpu: unexpected success >&2

		exit 1

	elif ! cpu_is_online $cpu; then

	elif ! cpu_is_online $cpu; then

		echo $FUNCNAME $cpu: unexpected offline >&2

		echo $FUNCNAME $cpu: unexpected offline >&2

		exit 1

	fi

	fi

}

}