Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8f87e626 authored by Johan Hovold's avatar Johan Hovold Committed by David S. Miller
Browse files

net: stmmac: dwmac-oxnas: fix of-node leak 



Use the syscon lookup-by-phandle helper so that the reference taken by
of_parse_phandle() is released when done with the node.

Fixes: 5ed74140 ("net: stmmac: Add OXNAS Glue Driver")
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 4e5da369

drivers/net/ethernet/stmicro/stmmac/dwmac-oxnas.c

+2 −8
Original line number Diff line number Diff line
@@ -109,16 +109,9 @@ static int oxnas_dwmac_probe(struct platform_device *pdev) 
{

	struct plat_stmmacenet_data *plat_dat;

	struct stmmac_resources stmmac_res;

	struct device_node *sysctrl;

	struct oxnas_dwmac *dwmac;

	int ret;



	sysctrl = of_parse_phandle(pdev->dev.of_node, "oxsemi,sys-ctrl", 0);

	if (!sysctrl) {

		dev_err(&pdev->dev, "failed to get sys-ctrl node\n");

		return -EINVAL;

	}



	ret = stmmac_get_platform_resources(pdev, &stmmac_res);

	if (ret)

		return ret;
@@ -134,7 +127,8 @@ static int oxnas_dwmac_probe(struct platform_device *pdev) 
	dwmac->dev = &pdev->dev;

	plat_dat->bsp_priv = dwmac;



	dwmac->regmap = syscon_node_to_regmap(sysctrl);

	dwmac->regmap = syscon_regmap_lookup_by_phandle(pdev->dev.of_node,

							"oxsemi,sys-ctrl");

	if (IS_ERR(dwmac->regmap)) {

		dev_err(&pdev->dev, "failed to have sysctrl regmap\n");

		return PTR_ERR(dwmac->regmap);