regmap-irq: do not write mask register if mask_base is zero (8f14cf15) · Commits · e / devices / android_kernel_fairphone_FP4

commit 7151449fe7fa5962c6153355f9779d6be99e8e97 upstream. If client have not provided the mask base register then do not write into the mask register. Signed-off-by:

Laxman Dewangan <ldewangan@nvidia.com> Signed-off-by:

Jinyoung Park <jinyoungp@nvidia.com> Signed-off-by:

Venkat Reddy Talla <vreddytalla@nvidia.com> Signed-off-by:

Mark Zhang <markz@nvidia.com> Signed-off-by:

Mark Brown <broonie@kernel.org> Signed-off-by:

Greg Kroah-Hartman <gregkh@linuxfoundation.org>

drivers/base/regmap/regmap-irq.c

+6 −0

Original line number	Diff line number	Diff line
		@@ -91,6 +91,9 @@ static void regmap_irq_sync_unlock(struct irq_data *data)
		* suppress pointless writes.
		*/
		for (i = 0; i < d->chip->num_regs; i++) {
		if (!d->chip->mask_base)
		continue;

		reg = d->chip->mask_base +
		(i * map->reg_stride * d->irq_reg_stride);
		if (d->chip->mask_invert) {
		@@ -526,6 +529,9 @@ int regmap_add_irq_chip(struct regmap *map, int irq, int irq_flags,
		/* Mask all the interrupts by default */
		for (i = 0; i < chip->num_regs; i++) {
		d->mask_buf[i] = d->mask_buf_def[i];
		if (!chip->mask_base)
		continue;

		reg = chip->mask_base +
		(i * map->reg_stride * d->irq_reg_stride);
		if (chip->mask_invert)