Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8e99fc5f authored by Giuseppe Cavallaro's avatar Giuseppe Cavallaro Committed by David S. Miller
Browse files

stmmac: do not poll phy handler when attach a switch 



This patch avoids to call the stmmac_adjust_link when
the driver is connected to a switch by using the FIXED_PHY
support. Prior this patch the phydev->irq was set as PHY_POLL
so periodically the phy handler was invoked spending useless
time because the link cannot actually change.
Note that the stmmac_adjust_link will be called just one
time and this guarantees that the ST glue logic will be
setup according to the mode and speed fixed.

Signed-off-by: default avatarGiuseppe Cavallaro <peppe.cavallaro@st.com>
Signed-off-by: default avatarAlexandre TORGUE <alexandre.torgue@st.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 0e80bdc9

drivers/net/ethernet/stmicro/stmmac/stmmac_main.c

+5 −0
Original line number Diff line number Diff line
@@ -866,6 +866,11 @@ static int stmmac_init_phy(struct net_device *dev) 
		phy_disconnect(phydev);

		return -ENODEV;

	}



	/* If attached to a switch, there is no reason to poll phy handler */

	if (!strcmp(priv->plat->phy_bus_name, "fixed"))

		phydev->irq = PHY_IGNORE_INTERRUPT;



	pr_debug("stmmac_init_phy:  %s: attached to PHY (UID 0x%x)"

		 " Link = %d\n", dev->name, phydev->phy_id, phydev->link);