Commit 8e94de44 authored Oct 08, 2019 by Baolin Wang Committed by Greg Kroah-Hartman Jan 23, 2020

clk: sprd: Use IS_ERR() to validate the return value of syscon_regmap_lookup_by_phandle()

commit 9629dbdabd1983ef53f125336e1d62d77b1620f9 upstream.

The syscon_regmap_lookup_by_phandle() will never return NULL, thus use
IS_ERR() to validate the return value instead of IS_ERR_OR_NULL().

Fixes: d41f59fd ("clk: sprd: Add common infrastructure")
Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
Link: https://lkml.kernel.org/r/1995139bee5248ff3e9d46dc715968f212cfc4cc.1570520268.git.baolin.wang@linaro.org

Signed-off-by: Stephen Boyd <sboyd@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent eaac3dc7

drivers/clk/sprd/common.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -45,7 +45,7 @@ int sprd_clk_regmap_init(struct platform_device *pdev,

	if (of_find_property(node, "sprd,syscon", NULL)) {		if (of_find_property(node, "sprd,syscon", NULL)) {
	regmap = syscon_regmap_lookup_by_phandle(node, "sprd,syscon");		regmap = syscon_regmap_lookup_by_phandle(node, "sprd,syscon");
	if (IS_ERR_OR_NULL(regmap)) {		if (IS_ERR(regmap)) {
	pr_err("%s: failed to get syscon regmap\n", __func__);		pr_err("%s: failed to get syscon regmap\n", __func__);
	return PTR_ERR(regmap);		return PTR_ERR(regmap);
	}		}