Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8e8ef50b authored by Vivien Didelot's avatar Vivien Didelot Committed by David S. Miller
Browse files

net: dsa: legacy: don't unmask port bitmaps 



The legacy code does not unmask the cpu_port_mask and dsa_port_mask as
stated. But this is done on the error path and those masks won't be used
after that. So instead of fixing the bit operation, simply remove it.

Fixes: 83c0afae ("net: dsa: Add new binding implementation")
Signed-off-by: default avatarVivien Didelot <vivien.didelot@savoirfairelinux.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent c3c9f441

net/dsa/legacy.c

+0 −4
Original line number Diff line number Diff line
@@ -272,10 +272,6 @@ static void dsa_switch_destroy(struct dsa_switch *ds) 
		if (!(dsa_is_cpu_port(ds, port) || dsa_is_dsa_port(ds, port)))

			continue;

		dsa_cpu_dsa_destroy(&ds->ports[port]);



		/* Clearing a bit which is not set does no harm */

		ds->cpu_port_mask |= ~(1 << port);

		ds->dsa_port_mask |= ~(1 << port);

	}



	if (ds->slave_mii_bus && ds->ops->phy_read)