Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8e09b7d2 authored by Lino Sanfilippo's avatar Lino Sanfilippo Committed by John W. Linville
Browse files

wil6210: Fix potential memory leaks on error paths 



Fix missing memory deallocation on error paths in wil_write_file_wmi()
and wil_write_file_txmgmt().

Reported-by: default avatarAhmed Tamrawi <ahmedtamrawi@gmail.com>
Signed-off-by: default avatarLino Sanfilippo <LinoSanfilippo@gmx.de>
Signed-off-by: default avatarVladimir Kondratiev <qca_vkondrat@qca.qualcomm.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent cbe1bc23

drivers/net/wireless/ath/wil6210/debugfs.c

+6 −2
Original line number Diff line number Diff line
@@ -573,8 +573,10 @@ static ssize_t wil_write_file_txmgmt(struct file *file, const char __user *buf, 
	if (!frame)

		return -ENOMEM;



	if (copy_from_user(frame, buf, len))

	if (copy_from_user(frame, buf, len)) {

		kfree(frame);

		return -EIO;

	}



	params.buf = frame;

	params.len = len;
@@ -614,8 +616,10 @@ static ssize_t wil_write_file_wmi(struct file *file, const char __user *buf, 
		return -ENOMEM;



	rc = simple_write_to_buffer(wmi, len, ppos, buf, len);

	if (rc < 0)

	if (rc < 0) {

		kfree(wmi);

		return rc;

	}



	cmd = &wmi[1];

	cmdid = le16_to_cpu(wmi->id);