Commit 8df24d57 authored Jan 17, 2018 by Laurent Pinchart Committed by Liviu Dudau Jul 31, 2018

drm: arm: hdlcd: Don't destroy plane manually in hdlcd_setup_crtc()



The top-level error handler calls drm_mode_config_cleanup() which will
destroy all planes. There's no need to destroy them manually in lower
error handlers.

Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Signed-off-by: Liviu Dudau <liviu.dudau@arm.com>

parent 1785dbc4

drivers/gpu/drm/arm/hdlcd_crtc.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -334,10 +334,8 @@ int hdlcd_setup_crtc(struct drm_device *drm)

		ret = drm_crtc_init_with_planes(drm, &hdlcd->crtc, primary, NULL,
		&hdlcd_crtc_funcs, NULL);
		if (ret) {
		hdlcd_plane_destroy(primary);
		if (ret)
		return ret;
		}

		drm_crtc_helper_add(&hdlcd->crtc, &hdlcd_crtc_helper_funcs);
		return 0;