Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8dcf07be authored by Bart Van Assche's avatar Bart Van Assche
Browse files

target: Minimize #include directives 



Remove superfluous #include directives from the include/target/*.h
files. Add missing #include directives to other *.h and *.c files.
Use forward declarations for structures where possible. This
change reduces the build time for make M=drivers/target on my
laptop from 27.1s to 18.7s or by about 30%.

Signed-off-by: default avatarBart Van Assche <bart.vanassche@sandisk.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Bryant G. Ly <bryantly@linux.vnet.ibm.com>
parent f5045724

drivers/target/iscsi/iscsi_target.c

+2 −0
Original line number Diff line number Diff line
@@ -23,7 +23,9 @@ 
#include <linux/module.h>

#include <linux/vmalloc.h>

#include <linux/idr.h>

#include <linux/delay.h>

#include <asm/unaligned.h>

#include <net/ipv6.h>

#include <scsi/scsi_proto.h>

#include <scsi/iscsi_proto.h>

#include <scsi/scsi_tcq.h>

drivers/target/iscsi/iscsi_target.h

+12 −0
Original line number Diff line number Diff line 
#ifndef ISCSI_TARGET_H

#define ISCSI_TARGET_H



#include <linux/types.h>

#include <linux/spinlock.h>



struct iscsi_cmd;

struct iscsi_conn;

struct iscsi_np;

struct iscsi_portal_group;

struct iscsi_session;

struct iscsi_tpg_np;

struct kref;

struct sockaddr_storage;



extern struct iscsi_tiqn *iscsit_get_tiqn_for_login(unsigned char *);

extern struct iscsi_tiqn *iscsit_get_tiqn(unsigned char *, int);

extern void iscsit_put_tiqn_for_login(struct iscsi_tiqn *);

drivers/target/iscsi/iscsi_target_auth.c

+1 −1
Original line number Diff line number Diff line
@@ -20,8 +20,8 @@ 
#include <linux/kernel.h>

#include <linux/string.h>

#include <linux/err.h>

#include <linux/random.h>

#include <linux/scatterlist.h>



#include <target/iscsi/iscsi_target_core.h>

#include "iscsi_target_nego.h"

#include "iscsi_target_auth.h"

drivers/target/iscsi/iscsi_target_auth.h

+5 −0
Original line number Diff line number Diff line 
#ifndef _ISCSI_CHAP_H_

#define _ISCSI_CHAP_H_



#include <linux/types.h>



#define CHAP_DIGEST_UNKNOWN	0

#define CHAP_DIGEST_MD5		5

#define CHAP_DIGEST_SHA		6
@@ -18,6 +20,9 @@ 
#define CHAP_STAGE_CLIENT_NRIC	4

#define CHAP_STAGE_SERVER_NR	5



struct iscsi_node_auth;

struct iscsi_conn;



extern u32 chap_main_loop(struct iscsi_conn *, struct iscsi_node_auth *, char *, char *,

				int *, int *);

drivers/target/iscsi/iscsi_target_configfs.c

+2 −1
Original line number Diff line number Diff line
@@ -21,10 +21,11 @@ 
#include <linux/ctype.h>

#include <linux/export.h>

#include <linux/inet.h>

#include <linux/module.h>

#include <net/ipv6.h>

#include <target/target_core_base.h>

#include <target/target_core_fabric.h>

#include <target/iscsi/iscsi_transport.h>



#include <target/iscsi/iscsi_target_core.h>

#include "iscsi_target_parameters.h"

#include "iscsi_target_device.h"