Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8db63f53 authored by Masahiro Yamada's avatar Masahiro Yamada Committed by Linus Walleij
Browse files

pinctrl: stm32: select IRQ_DOMAIN_HIERARCHY instead of depends on 



Drivers that need IRQ_DOMAIN_HIERARCHY should "select" it, but
drivers/pinctrl/stm32/Kconfig is the only exception that uses
"depends on" syntax.  This prevents GPIO drivers from select'ing
IRQ_DOMAIN_HIERARCHY.

For example, if I add "select IRQ_DOMAIN_HIERARCHY" to GPIO_XGENE_SB,
I get the following recursive dependency error.

drivers/gpio/Kconfig:13:error: recursive dependency detected!
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"
drivers/gpio/Kconfig:13:	symbol GPIOLIB is selected by PINCTRL_STM32
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"
drivers/pinctrl/stm32/Kconfig:3:	symbol PINCTRL_STM32 is selected by PINCTRL_STM32F429
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"
drivers/pinctrl/stm32/Kconfig:11:	symbol PINCTRL_STM32F429 depends on IRQ_DOMAIN_HIERARCHY
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"
kernel/irq/Kconfig:67:	symbol IRQ_DOMAIN_HIERARCHY is selected by GPIO_XGENE_SB
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"
drivers/gpio/Kconfig:502:	symbol GPIO_XGENE_SB depends on GPIOLIB

Signed-off-by: default avatarMasahiro Yamada <yamada.masahiro@socionext.com>
Tested-by: default avatarAlexandre TORGUE <alexandre.torgue@st.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent fa8f6d06

drivers/pinctrl/stm32/Kconfig

+5 −4
Original line number Diff line number Diff line
@@ -6,29 +6,30 @@ config PINCTRL_STM32 
	select PINMUX

	select GENERIC_PINCONF

	select GPIOLIB

	select IRQ_DOMAIN_HIERARCHY

	select MFD_SYSCON



config PINCTRL_STM32F429

	bool "STMicroelectronics STM32F429 pin control" if COMPILE_TEST && !MACH_STM32F429

	depends on OF && IRQ_DOMAIN_HIERARCHY

	depends on OF

	default MACH_STM32F429

	select PINCTRL_STM32



config PINCTRL_STM32F469

	bool "STMicroelectronics STM32F469 pin control" if COMPILE_TEST && !MACH_STM32F469

	depends on OF && IRQ_DOMAIN_HIERARCHY

	depends on OF

	default MACH_STM32F469

	select PINCTRL_STM32



config PINCTRL_STM32F746

	bool "STMicroelectronics STM32F746 pin control" if COMPILE_TEST && !MACH_STM32F746

	depends on OF && IRQ_DOMAIN_HIERARCHY

	depends on OF

	default MACH_STM32F746

	select PINCTRL_STM32



config PINCTRL_STM32H743

	bool "STMicroelectronics STM32H743 pin control" if COMPILE_TEST && !MACH_STM32H743

	depends on OF && IRQ_DOMAIN_HIERARCHY

	depends on OF

	default MACH_STM32H743

	select PINCTRL_STM32

endif