Commit 8daef508 authored Apr 23, 2016 by Colin Ian King Committed by Arnaldo Carvalho de Melo Apr 25, 2016

perf tests: Replace assignment with comparison on assert check



The current assert check is checking an assignment, which will always be
true.  Instead, the assert should be checking if scale is equal to 0.122

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/1461419154-16918-1-git-send-email-colin.king@canonical.com


Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

parent 3b556bce

tools/perf/tests/event_update.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -30,7 +30,7 @@ static int process_event_scale(struct perf_tool *tool __maybe_unused,

		TEST_ASSERT_VAL("wrong id", ev->id == 123);
		TEST_ASSERT_VAL("wrong id", ev->type == PERF_EVENT_UPDATE__SCALE);
		TEST_ASSERT_VAL("wrong scale", ev_data->scale = 0.123);
		TEST_ASSERT_VAL("wrong scale", ev_data->scale == 0.123);
		return 0;
		}