Commit 8d77e235 authored Jul 12, 2023 by Minjie Du Committed by Greg Kroah-Hartman Sep 23, 2023

drivers: clk: keystone: Fix parameter judgment in _of_pll_clk_init()



[ Upstream commit a995c50db887ef97f3160775aef7d772635a6f6e ]

The function clk_register_pll() may return NULL or an ERR_PTR. Don't
treat an ERR_PTR as valid.

Signed-off-by: Minjie Du <duminjie@vivo.com>
Link: https://lore.kernel.org/r/20230712102246.10348-1-duminjie@vivo.com


Fixes: b9e0d40c ("clk: keystone: add Keystone PLL clock driver")
[sboyd@kernel.org: Reword commit text]
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent ade463bc

drivers/clk/keystone/pll.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -213,7 +213,7 @@ static void __init _of_pll_clk_init(struct device_node *node, bool pllctrl)
		}

		clk = clk_register_pll(NULL, node->name, parent_name, pll_data);
		if (clk) {
		if (!IS_ERR_OR_NULL(clk)) {
		of_clk_add_provider(node, of_clk_src_simple_get, clk);
		return;
		}