Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8d0a69d7 authored by LABBE Corentin's avatar LABBE Corentin Committed by Stephen Boyd
Browse files

clk: palmas: fix a possible NULL dereference 



of_match_device could return NULL, and so cause a NULL pointer
dereference later.
Even if the probability of this case is very low, fixing it made
static analyzers happy.

Solving this with of_device_get_match_data made also code simplier.

Reported-by: coverity (CID 1324137)
Signed-off-by: default avatarLABBE Corentin <clabbe.montjoie@gmail.com>
Signed-off-by: default avatarStephen Boyd <sboyd@codeaurora.org>
parent 93fffbbe

drivers/clk/clk-palmas.c

+3 −3
Original line number Diff line number Diff line
@@ -241,13 +241,13 @@ static int palmas_clks_probe(struct platform_device *pdev) 
	struct palmas *palmas = dev_get_drvdata(pdev->dev.parent);

	struct device_node *node = pdev->dev.of_node;

	const struct palmas_clks_of_match_data *match_data;

	const struct of_device_id *match;

	struct palmas_clock_info *cinfo;

	struct clk *clk;

	int ret;



	match = of_match_device(palmas_clks_of_match, &pdev->dev);

	match_data = match->data;

	match_data = of_device_get_match_data(&pdev->dev);

	if (!match_data)

		return 1;



	cinfo = devm_kzalloc(&pdev->dev, sizeof(*cinfo), GFP_KERNEL);

	if (!cinfo)