Commit 8cc31116 authored Feb 20, 2017 by Andrzej Hajda Committed by Rafael J. Wysocki Feb 23, 2017

PM / OPP: fix off-by-one bug in dev_pm_opp_get_max_volt_latency loop



Reading array at given index before checking if index is valid results in
illegal memory access.

The bug was detected using KASAN framework.

Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

parent 0764c604

drivers/base/power/opp/core.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -231,7 +231,8 @@ unsigned long dev_pm_opp_get_max_volt_latency(struct device *dev)
		* The caller needs to ensure that opp_table (and hence the regulator)
		* isn't freed, while we are executing this routine.
		*/
		for (i = 0; reg = regulators[i], i < count; i++) {
		for (i = 0; i < count; i++) {
		reg = regulators[i];
		ret = regulator_set_voltage_time(reg, uV[i].min, uV[i].max);
		if (ret > 0)
		latency_ns += ret * 1000;