Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8c677541 authored by Boris Brezillon's avatar Boris Brezillon
Browse files

mtd: nand: denali: Avoid using ecc->code_buf as a temporary buffer 



ECC bytes are contiguous in the ->oob_poi buffer, which means we don't
have to copy them into ->code_buf (here used as a temporary buffer)
before passing them to the nand_check_erased_ecc_chunk() function.

This change will allow us to allocate ecc->{code,calc}_buf only when
ecc->calculate() or ecc->correct() is specified.

Signed-off-by: default avatarBoris Brezillon <boris.brezillon@free-electrons.com>
Acked-by: default avatarMasahiro Yamada <yamada.masahiro@socionext.com>
parent 98dea8d7

drivers/mtd/nand/denali.c

+3 −7
Original line number Diff line number Diff line
@@ -330,16 +330,12 @@ static int denali_check_erased_page(struct mtd_info *mtd, 
				    unsigned long uncor_ecc_flags,

				    unsigned int max_bitflips)

{

	uint8_t *ecc_code = chip->ecc.code_buf;

	struct denali_nand_info *denali = mtd_to_denali(mtd);

	uint8_t *ecc_code = chip->oob_poi + denali->oob_skip_bytes;

	int ecc_steps = chip->ecc.steps;

	int ecc_size = chip->ecc.size;

	int ecc_bytes = chip->ecc.bytes;

	int i, ret, stat;



	ret = mtd_ooblayout_get_eccbytes(mtd, ecc_code, chip->oob_poi, 0,

					 chip->ecc.total);

	if (ret)

		return ret;

	int i, stat;



	for (i = 0; i < ecc_steps; i++) {

		if (!(uncor_ecc_flags & BIT(i)))