Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8c66eece authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Lee Jones
Browse files

mfd: sec-core: Fix I2C dummy device resource leak on probe failure 



Dummy I2C device allocated in sec_pmic_probe() leaked if
devm_regmap_init_i2c() failed. Unregister it before returning from
probe.

Signed-off-by: default avatarKrzysztof Kozlowski <k.kozlowski@samsung.com>
Reviewed-by: default avatarSachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
parent 53c31b34

drivers/mfd/sec-core.c

+4 −3
Original line number Diff line number Diff line
@@ -347,7 +347,7 @@ static int sec_pmic_probe(struct i2c_client *i2c, 
		ret = PTR_ERR(sec_pmic->regmap_rtc);

		dev_err(&i2c->dev, "Failed to allocate RTC register map: %d\n",

			ret);

		return ret;

		goto err_regmap_rtc;

	}



	if (pdata && pdata->cfg_pmic_irq)
@@ -388,14 +388,15 @@ static int sec_pmic_probe(struct i2c_client *i2c, 
	}



	if (ret)

		goto err;

		goto err_mfd;



	device_init_wakeup(sec_pmic->dev, sec_pmic->wakeup);



	return ret;



err:

err_mfd:

	sec_irq_exit(sec_pmic);

err_regmap_rtc:

	i2c_unregister_device(sec_pmic->rtc);

	return ret;

}