Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8c46cf30 authored by Axel Lin's avatar Axel Lin Committed by Samuel Ortiz
Browse files

mfd: Fix wrong wm8350-core kfree in error path 



This patch includes below fixes:
1. fix wm8350_create_cache error path
   make sure wm8350->reg_cache is freed in error path.
2. fix wm8350_device_init error path
   no need to kfree(wm8350->reg_cache) in the case of goto out.

Signed-off-by: default avatarAxel Lin <axel.lin@gmail.com>
Acked-by: default avatarMark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: default avatarSamuel Ortiz <sameo@linux.intel.com>
parent fccbd21f

drivers/mfd/wm8350-core.c

+4 −2
Original line number Diff line number Diff line
@@ -536,6 +536,7 @@ static int wm8350_create_cache(struct wm8350 *wm8350, int type, int mode) 
	}



out:

	kfree(wm8350->reg_cache);

	return ret;

}
@@ -700,7 +701,7 @@ int wm8350_device_init(struct wm8350 *wm8350, int irq, 


	ret = wm8350_irq_init(wm8350, irq, pdata);

	if (ret < 0)

		goto err;

		goto err_free;



	if (wm8350->irq_base) {

		ret = request_threaded_irq(wm8350->irq_base +
@@ -738,8 +739,9 @@ int wm8350_device_init(struct wm8350 *wm8350, int irq, 


err_irq:

	wm8350_irq_exit(wm8350);

err:

err_free:

	kfree(wm8350->reg_cache);

err:

	return ret;

}

EXPORT_SYMBOL_GPL(wm8350_device_init);