Commit 8bbf5b42 authored Mar 08, 2018 by Arvind Yadav Committed by Thierry Reding Mar 28, 2018

pwm: sysfs: Use put_device() instead of kfree()



Never directly free @dev after calling device_register(), even if it
returned an error! Always use put_device() to give up the reference
initialized.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>

parent 8422c743

drivers/pwm/sysfs.c

+2 −1

Original line number	Original line	Diff line number	Diff line
	@@ -273,7 +273,8 @@ static int pwm_export_child(struct device parent, struct pwm_device pwm)
	ret = device_register(&export->child);		ret = device_register(&export->child);
	if (ret) {		if (ret) {
	clear_bit(PWMF_EXPORTED, &pwm->flags);		clear_bit(PWMF_EXPORTED, &pwm->flags);
	kfree(export);		put_device(&export->child);
			export = NULL;
	return ret;		return ret;
	}		}