Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8b649223 authored by Vinod Koul's avatar Vinod Koul Committed by Dan Williams
Browse files

intel_mid_dma: fix the WARN_ONs 



Moved the WARN_ON to BUG_ON, as WARN_ON if hit,
can cause null pointer derefrences

Signed-off-by: default avatarVinod Koul <vinod.koul@intel.com>
Signed-off-by: default avatarAlan Cox <alan@linux.intel.com>
Signed-off-by: default avatarDan Williams <dan.j.williams@intel.com>
parent 576e3c39

drivers/dma/intel_mid_dma.c

+3 −3
Original line number Diff line number Diff line
@@ -581,15 +581,15 @@ static struct dma_async_tx_descriptor *intel_mid_dma_prep_memcpy( 
	enum intel_mid_dma_width width = 0;



	pr_debug("MDMA: Prep for memcpy\n");

	WARN_ON(!chan);

	BUG_ON(!chan);

	if (!len)

		return NULL;



	mids = chan->private;

	WARN_ON(!mids);

	BUG_ON(!mids);



	midc = to_intel_mid_dma_chan(chan);

	WARN_ON(!midc);

	BUG_ON(!midc);



	pr_debug("MDMA:called for DMA %x CH %d Length %zu\n",

				midc->dma->pci_id, midc->ch_id, len);