Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8ae6ace1 authored by Laxman Dewangan's avatar Laxman Dewangan
Browse files

gpio: adp5520: Use devm_gpiochip_add_data() for gpio registration 



Use devm_gpiochip_add_data() for GPIO registration and remove the
call for gpiochip_remove() from error path.

Also remove the need of driver callback .remove.

Signed-off-by: default avatarLaxman Dewangan <ldewangan@nvidia.com>
Cc: Michael Hennerich <michael.hennerich@analog.com>
Acked-by: default avatarMichael Hennerich <michael.hennerich@analog.com>
parent daa994bf

drivers/gpio/gpio-adp5520.c

+1 −12
Original line number Diff line number Diff line
@@ -153,7 +153,7 @@ static int adp5520_gpio_probe(struct platform_device *pdev) 
		goto err;

	}



	ret = gpiochip_add_data(&dev->gpio_chip, dev);

	ret = devm_gpiochip_add_data(&pdev->dev, &dev->gpio_chip, dev);

	if (ret)

		goto err;
@@ -164,22 +164,11 @@ static int adp5520_gpio_probe(struct platform_device *pdev) 
	return ret;

}



static int adp5520_gpio_remove(struct platform_device *pdev)

{

	struct adp5520_gpio *dev;



	dev = platform_get_drvdata(pdev);

	gpiochip_remove(&dev->gpio_chip);



	return 0;

}



static struct platform_driver adp5520_gpio_driver = {

	.driver	= {

		.name	= "adp5520-gpio",

	},

	.probe		= adp5520_gpio_probe,

	.remove		= adp5520_gpio_remove,

};



module_platform_driver(adp5520_gpio_driver);