Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8a7411a2 authored by Theodore Ts'o's avatar Theodore Ts'o
Browse files

ext4: fix on-line resizing regression 

https://bugzilla.kernel.org/show_bug.cgi?id=25352



This regression was caused by commit a31437b8: "ext4: use
sb_issue_zeroout in setup_new_group_blocks", by accidentally dropping
the code which reserved the block group descriptor and inode table
blocks.

Signed-off-by: default avatar"Theodore Ts'o" <tytso@mit.edu>
parent b0c3844d

fs/ext4/resize.c

+5 −0
Original line number Diff line number Diff line
@@ -232,6 +232,8 @@ static int setup_new_group_blocks(struct super_block *sb, 
			       GFP_NOFS);

	if (err)

		goto exit_bh;

	for (i = 0, bit = gdblocks + 1; i < reserved_gdb; i++, bit++)

		ext4_set_bit(bit, bh->b_data);



	ext4_debug("mark block bitmap %#04llx (+%llu)\n", input->block_bitmap,

		   input->block_bitmap - start);
@@ -247,6 +249,9 @@ static int setup_new_group_blocks(struct super_block *sb, 
	err = sb_issue_zeroout(sb, block, sbi->s_itb_per_group, GFP_NOFS);

	if (err)

		goto exit_bh;

	for (i = 0, bit = input->inode_table - start;

	     i < sbi->s_itb_per_group; i++, bit++)

		ext4_set_bit(bit, bh->b_data);



	if ((err = extend_or_restart_transaction(handle, 2, bh)))

		goto exit_bh;