Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 89cb86c3 authored by Ashish Shah's avatar Ashish Shah Committed by David S. Miller
Browse files

i40e: remove support for vf unicast promiscuous mode 



Remove the ability of a VF to set unicast promiscuous mode.
Considered to be a security risk to allow VFs to receive traffic
intended for other VFs so don't allow it, simply ignore the flag.

Also fix it to send the correct seid to aq for multicast promiscuous set.

Change-ID: Icb9c49a281a8e9d3aeebf991ef1533ac82b84b14
Signed-off-by: default avatarAshish Shah <ashish.n.shah@intel.com>
Tested-by: default avatarJim Young <jamesx.m.young@intel.com>
Signed-off-by: default avatarAaron Brown <aaron.f.brown@intel.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 84a9208d

drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c

+3 −10
Original line number Diff line number Diff line
@@ -1163,8 +1163,8 @@ static int i40e_vc_config_promiscuous_mode_msg(struct i40e_vf *vf, 
	    (struct i40e_virtchnl_promisc_info *)msg;

	struct i40e_pf *pf = vf->pf;

	struct i40e_hw *hw = &pf->hw;

	struct i40e_vsi *vsi;

	bool allmulti = false;

	bool promisc = false;

	i40e_status aq_ret;



	if (!test_bit(I40E_VF_STAT_ACTIVE, &vf->vf_states) ||
@@ -1174,17 +1174,10 @@ static int i40e_vc_config_promiscuous_mode_msg(struct i40e_vf *vf, 
		aq_ret = I40E_ERR_PARAM;

		goto error_param;

	}



	if (info->flags & I40E_FLAG_VF_UNICAST_PROMISC)

		promisc = true;

	aq_ret = i40e_aq_set_vsi_unicast_promiscuous(hw, info->vsi_id,

						     promisc, NULL);

	if (aq_ret)

		goto error_param;



	vsi = pf->vsi[info->vsi_id];

	if (info->flags & I40E_FLAG_VF_MULTICAST_PROMISC)

		allmulti = true;

	aq_ret = i40e_aq_set_vsi_multicast_promiscuous(hw, info->vsi_id,

	aq_ret = i40e_aq_set_vsi_multicast_promiscuous(hw, vsi->seid,

						       allmulti, NULL);



error_param: