Commit 89a8f6d4 authored Jan 24, 2018 by Vitaly Kuznetsov Committed by Thomas Gleixner Jan 30, 2018

x86/hyperv: Check for required priviliges in hyperv_init()



In hyperv_init() its presumed that it always has access to VP index and
hypercall MSRs while according to the specification it should be checked if
it's allowed to access the corresponding MSRs before accessing them.

Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Stephen Hemminger <sthemmin@microsoft.com>
Cc: kvm@vger.kernel.org
Cc: Radim Krčmář <rkrcmar@redhat.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Cc: "Michael Kelley (EOSG)" <Michael.H.Kelley@microsoft.com>
Cc: Roman Kagan <rkagan@virtuozzo.com>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: devel@linuxdriverproject.org
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: "K. Y. Srinivasan" <kys@microsoft.com>
Cc: Cathy Avery <cavery@redhat.com>
Cc: Mohammed Gamal <mmorsy@redhat.com>
Link: https://lkml.kernel.org/r/20180124132337.30138-2-vkuznets@redhat.com

parent 72906f38

arch/x86/hyperv/hv_init.c

+8 −1

Original line number	Diff line number	Diff line
		@@ -110,12 +110,19 @@ static int hv_cpu_init(unsigned int cpu)
		*/
		void hyperv_init(void)
		{
		u64 guest_id;
		u64 guest_id, required_msrs;
		union hv_x64_msr_hypercall_contents hypercall_msr;

		if (x86_hyper_type != X86_HYPER_MS_HYPERV)
		return;

		/* Absolutely required MSRs */
		required_msrs = HV_X64_MSR_HYPERCALL_AVAILABLE \|
		HV_X64_MSR_VP_INDEX_AVAILABLE;

		if ((ms_hyperv.features & required_msrs) != required_msrs)
		return;

		/* Allocate percpu VP index */
		hv_vp_index = kmalloc_array(num_possible_cpus(), sizeof(*hv_vp_index),
		GFP_KERNEL);