Commit 89a82280 authored Oct 22, 2010 by Nicolas Kaiser Committed by David Woodhouse Oct 26, 2010

block2mtd: dubious assignment



When block2mtd_erase fails, a duplicated assignment instantly
changes instr->state from MTD_ERASE_FAILED to MTD_ERASE_DONE.

It looks to me like this might not be intended, or is it?

Signed-off-by: Nicolas Kaiser <nikai@nikai.net>
Acked-By: Joern Engel <joern@logfs.org>
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>

parent 0b824d2b

drivers/mtd/devices/block2mtd.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -91,7 +91,6 @@ static int block2mtd_erase(struct mtd_info mtd, struct erase_info instr)
		} else
		instr->state = MTD_ERASE_DONE;

		instr->state = MTD_ERASE_DONE;
		mtd_erase_callback(instr);
		return err;
		}