Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 894a2556 authored by Nicholas Bellinger's avatar Nicholas Bellinger
Browse files

tcm_usb_gadget: Fix enabled attribute failure 



Fix up tcm_usbg_tpg_store_enable() return value to propagate
usbg_attach() failure up to user-space if no HDC is found.

Reported-by: default avatarAndrzej Pietrasiewicz <andrzej.p@samsung.com>
Signed-off-by: default avatarAndrzej Pietrasiewicz <andrzej.p@samsung.com>
Acked-by: default avatarSebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: default avatarNicholas Bellinger <nab@linux-iscsi.org>
parent 4fef4e43

drivers/usb/gadget/legacy/tcm_usb_gadget.c

+9 −3
Original line number Diff line number Diff line
@@ -1505,10 +1505,14 @@ static ssize_t tcm_usbg_tpg_enable_store(struct config_item *item, 
	if (op > 1)

		return -EINVAL;



	if (op && tpg->gadget_connect)

	if (op && tpg->gadget_connect) {

		ret = -EINVAL;

		goto out;

	if (!op && !tpg->gadget_connect)

	}

	if (!op && !tpg->gadget_connect) {

		ret = -EINVAL;

		goto out;

	}



	if (op) {

		ret = usbg_attach(tpg);
@@ -1518,8 +1522,10 @@ static ssize_t tcm_usbg_tpg_enable_store(struct config_item *item, 
		usbg_detach(tpg);

	}

	tpg->gadget_connect = op;

out:



	return count;

out:

	return ret;

}



static ssize_t tcm_usbg_tpg_nexus_show(struct config_item *item, char *page)