Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 89331129 authored by Mauro Carvalho Chehab's avatar Mauro Carvalho Chehab
Browse files

media: staging: atomisp: declare static vars as such 



Fix a bunch of warnings:
	drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/bufq/src/bufq.c:93:23: warning: symbol 'css_queues' was not declared. Should it be static?
	drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/rmgr/src/rmgr_vbuf.c:27:32: warning: symbol 'handle_table' was not declared. Should it be static?
	drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/rmgr/src/rmgr_vbuf.c:32:30: warning: symbol 'refpool' was not declared. Should it be static?
	drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/rmgr/src/rmgr_vbuf.c:43:30: warning: symbol 'writepool' was not declared. Should it be static?
	drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/rmgr/src/rmgr_vbuf.c:54:30: warning: symbol 'hmmbufferpool' was not declared. Should it be static?
	drivers/staging/media/atomisp/pci/atomisp2/css2400/hive_isp_css_common/host/input_formatter.c:48:12: warning: symbol 'HIVE_IF_BIN_COPY' was not declared. Should it be static?
	drivers/staging/media/atomisp/pci/atomisp2/css2400/hive_isp_css_common/host/gp_timer.c:33:1: warning: symbol 'gp_timer_reg_load' was not declared. Should it be static?
	drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_sp.c:74:33: warning: symbol 'sh_css_sp_output' was not declared. Should it be static?
	drivers/staging/media/atomisp/pci/atomisp2/css2400/hive_isp_css_common/host/debug.c:32:25: warning: symbol 'debug_data' was not declared. Should it be static?
	drivers/staging/media/atomisp/pci/atomisp2/css2400/hive_isp_css_common/host/input_system.c:32:21: warning: symbol 'IB_BUFFER_NULL' was not declared. Should it be static?
	drivers/staging/media/atomisp/pci/atomisp2/css2400/hive_isp_css_common/host/input_system.c:647:24: warning: symbol 'config' was not declared. Should it be static?
	drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_params.c:2894:10: warning: symbol 'g_param_buffer_dequeue_count' was not declared. Should it be static?
	drivers/staging/media/atomisp/pci/atomisp2/css2400/sh_css_params.c:2895:10: warning: symbol 'g_param_buffer_enqueue_count' was not declared. Should it be static?

Acked-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
parent a0891a6e

drivers/staging/media/atomisp/pci/atomisp2/css2400/hive_isp_css_common/host/debug.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -29,7 +29,7 @@ 
hrt_address	debug_buffer_address = (hrt_address)-1;

hrt_address	debug_buffer_address = (hrt_address)-1;

hrt_vaddress	debug_buffer_ddr_address = (hrt_vaddress)-1;

hrt_vaddress	debug_buffer_ddr_address = (hrt_vaddress)-1;

/* The local copy */

/* The local copy */

debug_data_t		debug_data;

static debug_data_t		debug_data;

debug_data_t		*debug_data_ptr = &debug_data;

debug_data_t		*debug_data_ptr = &debug_data;





void debug_buffer_init(const hrt_address addr)

void debug_buffer_init(const hrt_address addr)

drivers/staging/media/atomisp/pci/atomisp2/css2400/hive_isp_css_common/host/gp_timer.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -29,7 +29,7 @@ gp_timer_reg_load(uint32_t reg); 
static void

static void

gp_timer_reg_store(uint32_t reg, uint32_t value);

gp_timer_reg_store(uint32_t reg, uint32_t value);





uint32_t

static uint32_t

gp_timer_reg_load(uint32_t reg)

gp_timer_reg_load(uint32_t reg)

{

{

	return ia_css_device_load_uint32(

	return ia_css_device_load_uint32(

drivers/staging/media/atomisp/pci/atomisp2/css2400/hive_isp_css_common/host/input_system.c

+2 −2
Original line number Original line Diff line number Diff line
@@ -29,7 +29,7 @@ 
#define ZERO (0x0)

#define ZERO (0x0)

#define ONE  (1U)

#define ONE  (1U)





const ib_buffer_t   IB_BUFFER_NULL = {0 ,0, 0 };

static const ib_buffer_t   IB_BUFFER_NULL = {0 ,0, 0 };





static input_system_error_t input_system_configure_channel(

static input_system_error_t input_system_configure_channel(

	const channel_cfg_t		channel);

	const channel_cfg_t		channel);
@@ -644,7 +644,7 @@ static inline void rx_channel_get_state( 
}

}





// MW: "2400" in the name is not good, but this is to avoid a naming conflict

// MW: "2400" in the name is not good, but this is to avoid a naming conflict

input_system_cfg2400_t config;

static input_system_cfg2400_t config;





static void receiver_rst(

static void receiver_rst(

	const rx_ID_t				ID)

	const rx_ID_t				ID)

drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/bufq/src/bufq.c

+3 −4
Original line number Original line Diff line number Diff line
@@ -90,12 +90,11 @@ struct sh_css_queues { 




#endif

#endif





struct sh_css_queues  css_queues;





/*******************************************************

/*******************************************************

*** Static variables

*** Static variables

********************************************************/

********************************************************/

static struct sh_css_queues css_queues;



static int buffer_type_to_queue_id_map[SH_CSS_MAX_SP_THREADS][IA_CSS_NUM_DYNAMIC_BUFFER_TYPE];

static int buffer_type_to_queue_id_map[SH_CSS_MAX_SP_THREADS][IA_CSS_NUM_DYNAMIC_BUFFER_TYPE];

static bool queue_availability[SH_CSS_MAX_SP_THREADS][SH_CSS_MAX_NUM_QUEUES];

static bool queue_availability[SH_CSS_MAX_SP_THREADS][SH_CSS_MAX_NUM_QUEUES];

drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/rmgr/src/rmgr_vbuf.c

+4 −4
Original line number Original line Diff line number Diff line
@@ -24,12 +24,12 @@ 
 * @brief VBUF resource handles

 * @brief VBUF resource handles

 */

 */

#define NUM_HANDLES 1000

#define NUM_HANDLES 1000

struct ia_css_rmgr_vbuf_handle handle_table[NUM_HANDLES];

static struct ia_css_rmgr_vbuf_handle handle_table[NUM_HANDLES];





/*

/*

 * @brief VBUF resource pool - refpool

 * @brief VBUF resource pool - refpool

 */

 */

struct ia_css_rmgr_vbuf_pool refpool = {

static struct ia_css_rmgr_vbuf_pool refpool = {

	false,			/* copy_on_write */

	false,			/* copy_on_write */

	false,			/* recycle */

	false,			/* recycle */

	0,			/* size */

	0,			/* size */
@@ -40,7 +40,7 @@ struct ia_css_rmgr_vbuf_pool refpool = { 
/*

/*

 * @brief VBUF resource pool - writepool

 * @brief VBUF resource pool - writepool

 */

 */

struct ia_css_rmgr_vbuf_pool writepool = {

static struct ia_css_rmgr_vbuf_pool writepool = {

	true,			/* copy_on_write */

	true,			/* copy_on_write */

	false,			/* recycle */

	false,			/* recycle */

	0,			/* size */

	0,			/* size */
@@ -51,7 +51,7 @@ struct ia_css_rmgr_vbuf_pool writepool = { 
/*

/*

 * @brief VBUF resource pool - hmmbufferpool

 * @brief VBUF resource pool - hmmbufferpool

 */

 */

struct ia_css_rmgr_vbuf_pool hmmbufferpool = {

static struct ia_css_rmgr_vbuf_pool hmmbufferpool = {

	true,			/* copy_on_write */

	true,			/* copy_on_write */

	true,			/* recycle */

	true,			/* recycle */

	32,			/* size */

	32,			/* size */