Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 88e80c62 authored by Eric Dumazet's avatar Eric Dumazet Committed by David S. Miller
Browse files

smsc75xx: fix smsc75xx_set_features()



If an attempt is made to disable RX checksums, USB adapter is changed
but netdev->features is not, because smsc75xx_set_features() returns a
non zero value.

This throws errors from netdev_rx_csum_fault() :
<devname>: hw csum failure

Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Cc: Steve Glendinning <steve.glendinning@shawell.net>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent b87b6194
Loading
Loading
Loading
Loading
+4 −3
Original line number Diff line number Diff line
@@ -954,11 +954,12 @@ static int smsc75xx_set_features(struct net_device *netdev,
	/* it's racing here! */

	ret = smsc75xx_write_reg(dev, RFE_CTL, pdata->rfe_ctl);
	if (ret < 0)
	if (ret < 0) {
		netdev_warn(dev->net, "Error writing RFE_CTL\n");

		return ret;
	}
	return 0;
}

static int smsc75xx_wait_ready(struct usbnet *dev, int in_pm)
{