Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 88af8304 authored by Hans Verkuil's avatar Hans Verkuil Committed by Mauro Carvalho Chehab
Browse files

[media] tvaudio: fix compiler warnings 



This is indeed a bug: balance and volume must be used to set the left and right
channel volume. Fixed.

Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 4c04b7a1

drivers/media/video/tvaudio.c

+6 −3
Original line number Diff line number Diff line
@@ -1695,11 +1695,14 @@ static int tvaudio_s_ctrl(struct v4l2_subdev *sd, 
	case V4L2_CID_AUDIO_BALANCE:

	{

		int volume, balance;



		if (!(desc->flags & CHIP_HAS_VOLUME))

			break;



		volume = max(chip->left, chip->right);

		balance = ctrl->value;

		chip->left = (min(65536 - balance, 32768) * volume) / 32768;

		chip->right = (min(balance, volume * (__u16)32768)) / 32768;



		chip_write(chip, desc->leftreg, desc->volfunc(chip->left));

		chip_write(chip, desc->rightreg, desc->volfunc(chip->right));