Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 88724bfa authored by NeilBrown's avatar NeilBrown
Browse files

md: wait for pending superblock updates before switching to read-only 



If a superblock update is pending, wait for it to complete before
letting md_set_readonly() switch to readonly.
Otherwise we might lose important information about a device having
failed.

For external arrays, waiting for superblock updates can wait on
user-space, so in that case, just return an error.

Reported-and-tested-by: default avatarShaohua Li <shli@fb.com>
Signed-off-by: default avatarNeilBrown <neilb@suse.com>
parent bcee19f4

drivers/md/md.c

+4 −0
Original line number Diff line number Diff line
@@ -5409,9 +5409,13 @@ static int md_set_readonly(struct mddev *mddev, struct block_device *bdev) 
		 * which will now never happen */

		wake_up_process(mddev->sync_thread->tsk);



	if (mddev->external && test_bit(MD_CHANGE_PENDING, &mddev->flags))

		return -EBUSY;

	mddev_unlock(mddev);

	wait_event(resync_wait, !test_bit(MD_RECOVERY_RUNNING,

					  &mddev->recovery));

	wait_event(mddev->sb_wait,

		   !test_bit(MD_CHANGE_PENDING, &mddev->flags));

	mddev_lock_nointr(mddev);



	mutex_lock(&mddev->open_mutex);