Commit 88660f7f authored Mar 05, 2015 by Michael S. Tsirkin Committed by Rusty Russell Mar 10, 2015

virtio_balloon: set DRIVER_OK before using device



virtio spec requires that all drivers set DRIVER_OK
before using devices. While balloon isn't yet
included in the virtio 1 spec, previous spec versions
also required this.

virtio balloon might violate this rule: probe calls
kthread_run before setting DRIVER_OK, which might run
immediately and cause balloon to inflate/deflate.

To fix, call virtio_device_ready before running the kthread.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Cc: stable@kernel.org

parent eeb8a7e8

drivers/virtio/virtio_balloon.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -499,6 +499,8 @@ static int virtballoon_probe(struct virtio_device *vdev)
		if (err < 0)
		goto out_oom_notify;

		virtio_device_ready(vdev);

		vb->thread = kthread_run(balloon, vb, "vballoon");
		if (IS_ERR(vb->thread)) {
		err = PTR_ERR(vb->thread);