Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8831a3f2 authored by Peter Hüwe's avatar Peter Hüwe Committed by David S. Miller
Browse files

isdn/hysdn: Convert to kstrtoul_from_user 



This patch replaces the code for getting an number from a
userspace buffer by a simple call to kstroul_from_user.
This makes it easier to read and less error prone.

Signed-off-by: default avatarPeter Huewe <peterhuewe@gmx.de>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent cf22f9a2

drivers/isdn/hysdn/hysdn_proclog.c

+1 −9
Original line number Diff line number Diff line
@@ -156,17 +156,9 @@ static ssize_t 
hysdn_log_write(struct file *file, const char __user *buf, size_t count, loff_t *off)

{

	int rc;

	unsigned char valbuf[128];

	hysdn_card *card = file->private_data;



	if (count > (sizeof(valbuf) - 1))

		count = sizeof(valbuf) - 1;	/* limit length */

	if (copy_from_user(valbuf, buf, count))

		return (-EFAULT);	/* copy failed */



	valbuf[count] = 0;	/* terminating 0 */



	rc = kstrtoul(valbuf, 0, &card->debug_flags);

	rc = kstrtoul_from_user(buf, count, 0, &card->debug_flags);

	if (rc < 0)

		return rc;

	hysdn_addlog(card, "debug set to 0x%lx", card->debug_flags);