Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 880a328e authored by Ido Schimmel's avatar Ido Schimmel Committed by Greg Kroah-Hartman
Browse files

mlxsw: core: Do not use WQ_MEM_RECLAIM for EMAD workqueue 



[ Upstream commit a8c133b06183c529c51cd0d54eb57d6b7078370c ]

The EMAD workqueue is used to handle retransmission of EMAD packets that
contain configuration data for the device's firmware.

Given the workers need to allocate these packets and that the code is
not called as part of memory reclaim path, remove the WQ_MEM_RECLAIM
flag.

Fixes: d965465b ("mlxsw: core: Fix possible deadlock")
Signed-off-by: default avatarIdo Schimmel <idosch@mellanox.com>
Acked-by: default avatarJiri Pirko <jiri@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarSasha Levin <alexander.levin@microsoft.com>
parent a80f62f7

drivers/net/ethernet/mellanox/mlxsw/core.c

+1 −1
Original line number Diff line number Diff line
@@ -568,7 +568,7 @@ static int mlxsw_emad_init(struct mlxsw_core *mlxsw_core) 
	if (!(mlxsw_core->bus->features & MLXSW_BUS_F_TXRX))

		return 0;



	emad_wq = alloc_workqueue("mlxsw_core_emad", WQ_MEM_RECLAIM, 0);

	emad_wq = alloc_workqueue("mlxsw_core_emad", 0, 0);

	if (!emad_wq)

		return -ENOMEM;

	mlxsw_core->emad_wq = emad_wq;