Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 878a3c37 authored by Chris Wilson's avatar Chris Wilson
Browse files

drm/i915: Fix flushing regression from 9af90d19 

Whilst moving the code around in 9af90d19, I dropped the or'ing in of
new write domains which would zero out the write domain for a render
target if later reused as a source later in the batch. This meant that
we might drop a required flush before reading from the render target.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=31043


Reported-by: default avatar <xunx.fang@intel.com>
Signed-off-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
parent e27d8538

drivers/gpu/drm/i915/i915_gem.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -3349,7 +3349,7 @@ i915_gem_execbuffer_relocate(struct drm_i915_gem_object *obj, 
		}

		}





		target_obj->pending_read_domains |= reloc.read_domains;

		target_obj->pending_read_domains |= reloc.read_domains;

		target_obj->pending_write_domain = reloc.write_domain;

		target_obj->pending_write_domain |= reloc.write_domain;





		/* If the relocation already has the right value in it, no

		/* If the relocation already has the right value in it, no

		 * more work needs to be done.

		 * more work needs to be done.