Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 871ff2eb authored by Geliang Tang's avatar Geliang Tang Committed by David S. Miller
Browse files

yam: use memdup_user 



Use memdup_user() helper instead of open-coding to simplify the code.

Signed-off-by: default avatarGeliang Tang <geliangtang@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 294316a4

drivers/net/hamradio/yam.c

+4 −6
Original line number Diff line number Diff line
@@ -976,12 +976,10 @@ static int yam_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd) 
	case SIOCYAMSMCS:

		if (netif_running(dev))

			return -EINVAL;		/* Cannot change this parameter when up */

		if ((ym = kmalloc(sizeof(struct yamdrv_ioctl_mcs), GFP_KERNEL)) == NULL)

			return -ENOBUFS;

		if (copy_from_user(ym, ifr->ifr_data, sizeof(struct yamdrv_ioctl_mcs))) {

			kfree(ym);

			return -EFAULT;

		}

		ym = memdup_user(ifr->ifr_data,

				 sizeof(struct yamdrv_ioctl_mcs));

		if (IS_ERR(ym))

			return PTR_ERR(ym);

		if (ym->bitrate > YAM_MAXBITRATE) {

			kfree(ym);

			return -EINVAL;