Commit 86edf562 authored Sep 28, 2018 by Amir Goldstein Committed by Greg Kroah-Hartman Nov 13, 2018

lockd: fix access beyond unterminated strings in prints



commit 93f38b6fae0ea8987e22d9e6c38f8dfdccd867ee upstream.

printk format used %*s instead of %.*s, so hostname_len does not limit
the number of bytes accessed from hostname.

Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Cc: stable@vger.kernel.org
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 18c1d28f

fs/lockd/host.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -341,7 +341,7 @@ struct nlm_host nlmsvc_lookup_host(const struct svc_rqst rqstp,
		};
		struct lockd_net *ln = net_generic(net, lockd_net_id);

		dprintk("lockd: %s(host='%*s', vers=%u, proto=%s)\n", __func__,
		dprintk("lockd: %s(host='%.*s', vers=%u, proto=%s)\n", __func__,
		(int)hostname_len, hostname, rqstp->rq_vers,
		(rqstp->rq_prot == IPPROTO_UDP ? "udp" : "tcp"));