Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 86b5ac87 authored by Jean Delvare's avatar Jean Delvare Committed by Greg KH
Browse files

[PATCH] I2C: via686a cleanups 



Here comes a small cleanup patch for the via686a driver. I noticed the
following two non-fatal problems:

1* The device parent is explicitely set, but it's not needed because the
i2c core will do as the client is registered.

2* snprintf is used where strlcpy would suffice.

Fixing them brings the via686a driver in line with what other similar
drivers do.

Signed-off-by: default avatarJean Delvare <khali@linux-fr.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 05985715

drivers/i2c/chips/via686a.c

+1 −2
Original line number Diff line number Diff line
@@ -651,10 +651,9 @@ static int via686a_detect(struct i2c_adapter *adapter, int address, int kind) 
	new_client->adapter = adapter;

	new_client->driver = &via686a_driver;

	new_client->flags = 0;

	new_client->dev.parent = &adapter->dev;



	/* Fill in the remaining client fields and put into the global list */

	snprintf(new_client->name, I2C_NAME_SIZE, client_name);

	strlcpy(new_client->name, client_name, I2C_NAME_SIZE);



	data->valid = 0;

	init_MUTEX(&data->update_lock);