Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 866a83bc authored by Veera Sundaram Sankaran's avatar Veera Sundaram Sankaran
Browse files

drm/msm/sde: avoid invalid fb validation in plane rot check 



Inline rotation validates the supported formats by
checking it against the format specified in the plane
framebuffer. Avoid validating the parameters in the
framebuffer during atomic-check cycle as the fb is
populated only during the commit cycle.

Change-Id: I98b59226916ab03af67c3e5c51d7316f8b59207b
Signed-off-by: default avatarVeera Sundaram Sankaran <veeras@codeaurora.org>
parent 92537f8c

drivers/gpu/drm/msm/sde/sde_plane.c

+5 −2
Original line number Diff line number Diff line
@@ -1636,8 +1636,6 @@ static int sde_plane_rot_atomic_check(struct drm_plane *plane, 
		struct sde_rect src;

		bool q16_data = true;



		msm_fmt = msm_framebuffer_format(state->fb);

		fmt = to_sde_format(msm_fmt);

		POPULATE_RECT(&src, state->src_x, state->src_y,

			state->src_w, state->src_h, q16_data);

		/*
@@ -1672,8 +1670,13 @@ static int sde_plane_rot_atomic_check(struct drm_plane *plane, 
			goto exit;

		}



		if (!sde_plane_enabled(state))

			goto exit;



		/* check for valid formats supported by inline rot */

		sde_kms = to_sde_kms(priv->kms);

		msm_fmt = msm_framebuffer_format(state->fb);

		fmt = to_sde_format(msm_fmt);

		ret = sde_format_validate_fmt(&sde_kms->base, fmt,

			psde->pipe_sblk->in_rot_format_list);

	}