Commit 865df9cb authored Dec 26, 2012 by Chuansheng Liu Committed by Mark Brown Dec 27, 2012

ASoC: core: fix the memory leak in case of device_add() failure



After called device_initialize(), even device_add() returns
error, we still need use the put_device() to release the reference
to call rtd_release(), which will do the free() action.

Signed-off-by: liu chuansheng <chuansheng.liu@intel.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

parent 5db1bc18

sound/soc/soc-core.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -1255,6 +1255,8 @@ static int soc_post_component_init(struct snd_soc_card *card,
		INIT_LIST_HEAD(&rtd->dpcm[SNDRV_PCM_STREAM_CAPTURE].fe_clients);
		ret = device_add(rtd->dev);
		if (ret < 0) {
		/* calling put_device() here to free the rtd->dev */
		put_device(rtd->dev);
		dev_err(card->dev,
		"ASoC: failed to register runtime device: %d\n", ret);
		return ret;