Commit 8649f431 authored Feb 08, 2012 by Bruce Allan Committed by Jeff Kirsher Feb 13, 2012

e1000e: potential incorrect return for e1000_setup_copper_link_80003es2lan



In the unlikely event that e1000e_setup_copper_link() returns an error,
the returned error code value is not propogated to the caller of
e1000_setup_copper_link_80003es2lan().

Signed-off-by: Bruce Allan <bruce.w.allan@intel.com>
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>

parent 520d6f22

drivers/net/ethernet/intel/e1000e/80003es2lan.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -1147,9 +1147,7 @@ static s32 e1000_setup_copper_link_80003es2lan(struct e1000_hw *hw)
		if (ret_val)
		return ret_val;

		ret_val = e1000e_setup_copper_link(hw);

		return 0;
		return e1000e_setup_copper_link(hw);
		}

		/**