Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 85cd083b authored by Chao Yu's avatar Chao Yu Committed by Jan Kara
Browse files

udf: avoid unneeded up_write when fail to add entry in ->symlink 



We have released the ->i_data_sem before invoking udf_add_entry(),
so in following error path, we should not release this lock again.

Signed-off-by: default avatarChao Yu <chao2.yu@samsung.com>
Signed-off-by: default avatarJan Kara <jack@suse.cz>
parent 7d1311b9

fs/udf/namei.c

+2 −1
Original line number Diff line number Diff line
@@ -1014,7 +1014,7 @@ static int udf_symlink(struct inode *dir, struct dentry *dentry, 


	fi = udf_add_entry(dir, dentry, &fibh, &cfi, &err);

	if (!fi)

		goto out_no_entry;

		goto out_fail;

	cfi.icb.extLength = cpu_to_le32(sb->s_blocksize);

	cfi.icb.extLocation = cpu_to_lelb(iinfo->i_location);

	if (UDF_SB(inode->i_sb)->s_lvid_bh) {
@@ -1036,6 +1036,7 @@ static int udf_symlink(struct inode *dir, struct dentry *dentry, 


out_no_entry:

	up_write(&iinfo->i_data_sem);

out_fail:

	inode_dec_link_count(inode);

	iput(inode);

	goto out;