Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8582fb59 authored by Joe Perches's avatar Joe Perches Committed by Linus Torvalds
Browse files

get_maintainer: quiet noisy implicit -f vcs_file_exists checking 

Checking command line filenames that are outside the git tree can emit a
noisy and confusing message.

Quiet that message by redirecting stderr.
Verify that the command was executed successfully.

Fixes: 4cad35a7 ("get_maintainer.pl: reduce need for command-line option -f")
Link: http://lkml.kernel.org/r/1970a1d2fecb258e384e2e4fdaacdc9ccf3e30a4.1470955439.git.joe@perches.com


Signed-off-by: default avatarJoe Perches <joe@perches.com>
Reported-by: default avatarWolfram Sang <wsa@the-dreams.de>
Tested-by: default avatarWolfram Sang <wsa@the-dreams.de>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 101b29a2

scripts/get_maintainer.pl

+3 −1
Original line number Diff line number Diff line
@@ -2136,9 +2136,11 @@ sub vcs_file_exists { 


    my $cmd = $VCS_cmds{"file_exists_cmd"};

    $cmd =~ s/(\$\w+)/$1/eeg;		# interpolate $cmd



    $cmd .= " 2>&1";

    $exists = &{$VCS_cmds{"execute_cmd"}}($cmd);



    return 0 if ($? != 0);



    return $exists;

}