Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8526bafc authored by Arnaldo Carvalho de Melo's avatar Arnaldo Carvalho de Melo
Browse files

perf test sdt: Handle realpath() failure 



It can return NULL, in which case we should bail out and remove the
directory created with mkdtemp(), which is stored in the "__tempdir"
variable, not in "tempdir".

Cc: Masami Hiramatsu <mhiramat@kernel.org>
Fixes: 8e5dc848 ("perf test: Add a test case for SDT event")
Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 4b4cd503

tools/perf/tests/sdt.c

+3 −1
Original line number Diff line number Diff line
@@ -83,6 +83,8 @@ int test__sdt_event(int subtests __maybe_unused) 
	}

	/* Note that buildid_dir must be an absolute path */

	tempdir = realpath(__tempdir, NULL);

	if (tempdir == NULL)

		goto error_rmdir;



	/* At first, scan itself */

	set_buildid_dir(tempdir);
@@ -100,7 +102,7 @@ int test__sdt_event(int subtests __maybe_unused) 


error_rmdir:

	/* Cleanup temporary buildid dir */

	rm_rf(tempdir);

	rm_rf(__tempdir);

error:

	free(tempdir);

	free(myself);