Commit 851346e5 authored Feb 26, 2020 by yangerkun Committed by Greg Kroah-Hartman Mar 20, 2020

slip: not call free_netdev before rtnl_unlock in slip_open



[ Upstream commit f596c87005f7b1baeb7d62d9a9e25d68c3dfae10 ]

As the description before netdev_run_todo, we cannot call free_netdev
before rtnl_unlock, fix it by reorder the code.

Signed-off-by: yangerkun <yangerkun@huawei.com>
Reviewed-by: Oliver Hartkopp <socketcan@hartkopp.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 797479da

drivers/net/slip/slip.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -863,7 +863,10 @@ static int slip_open(struct tty_struct *tty)
		tty->disc_data = NULL;
		clear_bit(SLF_INUSE, &sl->flags);
		sl_free_netdev(sl->dev);
		/* do not call free_netdev before rtnl_unlock */
		rtnl_unlock();
		free_netdev(sl->dev);
		return err;

		err_exit:
		rtnl_unlock();