Commit 84bc8868 authored Nov 13, 2014 by Vincent BENAYOUN Committed by David S. Miller Nov 14, 2014

inetdevice: fixed signed integer overflow



There could be a signed overflow in the following code.

The expression, (32-logmask) is comprised between 0 and 31 included.
It may be equal to 31.
In such a case the left shift will produce a signed integer overflow.
According to the C99 Standard, this is an undefined behavior.
A simple fix is to replace the signed int 1 with the unsigned int 1U.

Signed-off-by: Vincent BENAYOUN <vincent.benayoun@trust-in-soft.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent b23dc5a7

include/linux/inetdevice.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -242,7 +242,7 @@ static inline void in_dev_put(struct in_device *idev)
		static __inline__ __be32 inet_make_mask(int logmask)
		{
		if (logmask)
		return htonl(~((1<<(32-logmask))-1));
		return htonl(~((1U<<(32-logmask))-1));
		return 0;
		}