Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8487bfd9 authored by Jim Cromie's avatar Jim Cromie Committed by Rusty Russell
Browse files

kernel/params: replace DEBUGP with pr_debug 



Use more flexible pr_debug.  This allows:

  echo "module params +p" > /dbg/dynamic_debug/control

to turn on debug messages when needed.

Signed-off-by: default avatarJim Cromie <jim.cromie@gmail.com>
Signed-off-by: default avatarRusty Russell <rusty@rustcorp.com.au>
parent 5e124169

kernel/params.c

+4 −10
Original line number Diff line number Diff line
@@ -25,12 +25,6 @@ 
#include <linux/slab.h>

#include <linux/ctype.h>



#if 0

#define DEBUGP printk

#else

#define DEBUGP(fmt, a...)

#endif



/* Protects all parameters, and incidentally kmalloced_param list. */

static DEFINE_MUTEX(param_lock);
@@ -105,7 +99,7 @@ static int parse_one(char *param, 
			/* No one handled NULL, so do it here. */

			if (!val && params[i].ops->set != param_set_bool)

				return -EINVAL;

			DEBUGP("They are equal!  Calling %p\n",

			pr_debug("They are equal!  Calling %p\n",

			       params[i].ops->set);

			mutex_lock(&param_lock);

			err = params[i].ops->set(val, &params[i]);
@@ -115,11 +109,11 @@ static int parse_one(char *param, 
	}



	if (handle_unknown) {

		DEBUGP("Unknown argument: calling %p\n", handle_unknown);

		pr_debug("Unknown argument: calling %p\n", handle_unknown);

		return handle_unknown(param, val);

	}



	DEBUGP("Unknown argument `%s'\n", param);

	pr_debug("Unknown argument `%s'\n", param);

	return -ENOENT;

}
@@ -184,7 +178,7 @@ int parse_args(const char *name, 
{

	char *param, *val;



	DEBUGP("Parsing ARGS: %s\n", args);

	pr_debug("Parsing ARGS: %s\n", args);



	/* Chew leading spaces */

	args = skip_spaces(args);